Skip to content

FIX: Set input model to bedpostx for camino.TrackBedpostxProba #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

mick-d
Copy link
Contributor

@mick-d mick-d commented Jun 21, 2019

Summary

Fix command line generated to run probability tracking on bedpostx output with Camino

List of changes proposed in this PR (pull-request)

Acknowledgment

  • [x ] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

Codecov Report

Merging #2947 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
- Coverage   67.59%   67.59%   -0.01%     
==========================================
  Files         344      344              
  Lines       43747    43747              
  Branches     5456     5456              
==========================================
- Hits        29572    29570       -2     
+ Misses      13466    13461       -5     
- Partials      709      716       +7
Flag Coverage Δ
#smoketests 50.37% <ø> (ø) ⬆️
#unittests 65.03% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/camino/dti.py 77.91% <100%> (ø) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 66.5% <0%> (-1%) ⬇️
nipype/interfaces/io.py 55.07% <0%> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (ø) ⬆️
nipype/interfaces/dynamic_slicer.py 17.47% <0%> (ø) ⬆️
nipype/interfaces/nipy/preprocess.py 45.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fbc7cb...f473b39. Read the comment docs.

@effigies
Copy link
Member

What changed in the last four years? Has this always been a bug, or has there been an update in the underlying tool, and this is moving to be consistent with the latest version?

@mick-d
Copy link
Contributor Author

mick-d commented Jun 24, 2019

What changed in the last four years?

I used for the first time bedpostx + camino's probabilistic tractography for a project. Camino's code itself did not change in the last four years.

Has this always been a bug, or has there been an update in the underlying tool, and this is moving to be consistent with the latest version?

It has always been a bug (results were the same as deterministic tractography, and not much different from probabilistic tractography with a high connectivty threshold in terms of streamline count or the metric of interest). It is now consistent with the latest version of Camino (and Camino's version from 4 years ago).

@effigies effigies changed the title FIX: correct option for bedpostx probability tracking to work as attended FIX: Set input model to bedpostx for camino.TrackBedpostxProba Jun 25, 2019
@effigies effigies added this to the 1.2.1 milestone Jun 25, 2019
@effigies effigies merged commit 2588af7 into nipy:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants