Skip to content

[MAINT] Outsource get_filecopy_info() from interfaces #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2018

Conversation

oesteban
Copy link
Contributor

This PR outsources the responsibility of gathering copyfile information from the input spec.

This PR outsources the responsibility of gathering ``copyfile`` information from the input spec.
@codecov-io
Copy link

codecov-io commented Nov 25, 2018

Codecov Report

Merging #2798 into master will decrease coverage by 3.42%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
- Coverage   67.51%   64.08%   -3.43%     
==========================================
  Files         341      339       -2     
  Lines       43292    43244      -48     
  Branches     5368     5366       -2     
==========================================
- Hits        29229    27714    -1515     
- Misses      13362    14457    +1095     
- Partials      701     1073     +372
Flag Coverage Δ
#smoketests ?
#unittests 64.08% <81.81%> (-0.85%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/base.py 50% <ø> (-30.49%) ⬇️
nipype/interfaces/freesurfer/utils.py 60.8% <100%> (-2.14%) ⬇️
nipype/pipeline/engine/nodes.py 77.87% <100%> (-6.44%) ⬇️
nipype/interfaces/base/core.py 85.08% <50%> (-2.34%) ⬇️
nipype/interfaces/base/specs.py 86.7% <83.33%> (-6.48%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa94344...d9d55b7. Read the comment docs.

@oesteban oesteban requested a review from satra November 25, 2018 06:50
@satra satra merged commit 11f8eb2 into nipy:master Nov 25, 2018
@oesteban oesteban deleted the maint/strip-get-filecopy-info branch November 25, 2018 15:41
@effigies effigies added this to the 1.1.6 milestone Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants