Skip to content

Fix --fineTune arguments order for MeshFix command #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2018
Merged

Fix --fineTune arguments order for MeshFix command #2780

merged 5 commits into from
Nov 16, 2018

Conversation

MartinGrignard
Copy link
Contributor

Summary

This PR allows to use --fineTuneIn and --fineTuneOut instrutions from MeshFix input spec.

Fixes #2770 .

List of changes proposed in this PR (pull-request)

  • Add description to --fineTuneIn MeshFix input spec.
  • Set the order of the --fineTuneIn and --fineTuneOut MeshFix arguments.
  • Fix the fact that the command for --fineTuneOut was actually --fineTuneIn due to a copy-paste.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

Fix --fineTuneOut (previously --fineTuneIn was duplicated)
Previously the argument were given in a wrong order.
@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #2780 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
+ Coverage    67.5%   67.76%   +0.26%     
==========================================
  Files         340      341       +1     
  Lines       43271    43794     +523     
  Branches     5364     5546     +182     
==========================================
+ Hits        29211    29678     +467     
- Misses      13360    13400      +40     
- Partials      700      716      +16
Flag Coverage Δ
#smoketests 50.6% <ø> (ø) ⬆️
#unittests 65.23% <ø> (+0.31%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/meshfix.py 69.11% <ø> (ø) ⬆️
nipype/pipeline/plugins/multiproc.py 81.25% <0%> (-3.57%) ⬇️
nipype/utils/subprocess.py 87.31% <0%> (ø)
nipype/interfaces/base/core.py 89.56% <0%> (+1.42%) ⬆️
nipype/interfaces/base/support.py 82.28% <0%> (+4.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e475331...9b91e47. Read the comment docs.

@MartinGrignard MartinGrignard changed the title FIX #2770 Fix --fineTune arguments order for MeshFix command Nov 15, 2018
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@effigies effigies added this to the 1.1.6 milestone Nov 15, 2018
@effigies
Copy link
Member

Do you want to add yourself to the .zenodo.json?

@MartinGrignard
Copy link
Contributor Author

@effigies Yes it would be nice! Should I do it from the pull request?

@effigies effigies merged commit ffb8a16 into nipy:master Nov 16, 2018
@effigies
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants