Skip to content

ENH: Add 'sse' output to FSL DTIFit interface #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

divetea
Copy link

@divetea divetea commented Oct 24, 2018

Summary

Add Sum-Squared-Error to DTIFit output.

Fixes #2743 .

List of changes proposed in this PR (pull-request)

  • add 'sse' to DTIFitOutputSpec
  • add logic to ignore this output if the corresponding input-flag was not set

I was not able to run the tests since i cannot install all requirements on my work system.
My changes are very similar to the already existing 'save_tensor' input with 'tensor' output.
The logic to only add the output if the corresponding input-flag was defined and set to True, was only tested manually with an example dataset, since it depends on the actual output/file creation!
I did not find any tests for the 'save tensor' -> 'tensor' input-output pair, so i had no orientation how to approach this for my new output.
In fact i did not find any tests that go further than the correct assembly of the cmdline.

I think the approach to define a dictionary which maps an optional output to the corresponding input-flag is quite generic and might be useful in similar use-cases. In the old code 'save_tensor' was handled as a special case with some duplication.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies changed the title ENH: add optional output sse to FSL dtifit interface ENH: Add 'sse' output to FSL DTIFit interface Oct 24, 2018
@effigies effigies added this to the 1.1.4 milestone Oct 24, 2018
@effigies
Copy link
Member

LGTM. Thanks.

@effigies effigies merged commit 39675df into nipy:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSL dtifit add sse to outputspec
3 participants