ENH: Add 'sse' output to FSL DTIFit interface #2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Sum-Squared-Error to DTIFit output.
Fixes #2743 .
List of changes proposed in this PR (pull-request)
I was not able to run the tests since i cannot install all requirements on my work system.
My changes are very similar to the already existing 'save_tensor' input with 'tensor' output.
The logic to only add the output if the corresponding input-flag was defined and set to True, was only tested manually with an example dataset, since it depends on the actual output/file creation!
I did not find any tests for the 'save tensor' -> 'tensor' input-output pair, so i had no orientation how to approach this for my new output.
In fact i did not find any tests that go further than the correct assembly of the cmdline.
I think the approach to define a dictionary which maps an optional output to the corresponding input-flag is quite generic and might be useful in similar use-cases. In the old code 'save_tensor' was handled as a special case with some duplication.
Acknowledgment