Skip to content

[FIX] Typo in DWIExtract of Mrtrix3interface #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Conversation

atsuch
Copy link

@atsuch atsuch commented Jul 10, 2018

Fixes # .

Changes proposed in this pull request
-Fix a typo in Mrtrix3 interface, DWIExtract: arg str -nobzero changed to -no_bzero

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atsuch - is this a recent change or has this always been a typo? You'll need to run make specs and add the changed autotest to get the tests working

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #2634 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2634   +/-   ##
======================================
  Coverage    67.6%   67.6%           
======================================
  Files         340     340           
  Lines       43003   43003           
  Branches     5321    5321           
======================================
  Hits        29071   29071           
+ Misses      13233   13225    -8     
- Partials      699     707    +8
Flag Coverage Δ
#smoketests 50.52% <ø> (ø) ⬆️
#unittests 65.05% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/mrtrix3/utils.py 82.42% <100%> (ø) ⬆️
nipype/interfaces/dynamic_slicer.py 17.47% <0%> (ø) ⬆️
nipype/interfaces/io.py 54.68% <0%> (ø) ⬆️
nipype/interfaces/nipy/preprocess.py 45.79% <0%> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.27% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea4f1b...e41bb69. Read the comment docs.

@atsuch
Copy link
Author

atsuch commented Jul 11, 2018

Hello @mgxd, I think it has been there since this interface was added.

@atsuch
Copy link
Author

atsuch commented Jul 13, 2018

Hi @mgxd, I'm still not passing the tests.. any idea why??

@djarecka
Copy link
Collaborator

@atsuch - I've restarted your tests. It seems there were some problems with installation from debian

@mgxd mgxd added this to the 1.1.1 milestone Jul 13, 2018
@mgxd mgxd merged commit 6c00f85 into nipy:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants