Skip to content

[FIX] Typo #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2018
Merged

[FIX] Typo #2628

merged 4 commits into from
Jul 13, 2018

Conversation

weningerleon
Copy link
Contributor

Fixes #2614

Change argstr burnin_noard of FSLCommandInputSpec

Changes proposed in this pull request:
The correct argument for FSL bedpostx is burnin_noard, not burninnoard

burninnoard -> burnin_noard of FSLCommandInputSpec
Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @weningerleon - to get the tests passing you will have to run make specs in your local fork and add the changed autotest to this PR.

@effigies
Copy link
Member

effigies commented Jul 2, 2018

I think you'll also need to merge master after #2618 was merged...

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #2628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2628   +/-   ##
======================================
  Coverage    67.6%   67.6%           
======================================
  Files         340     340           
  Lines       43003   43003           
  Branches     5321    5321           
======================================
  Hits        29071   29071           
  Misses      13233   13233           
  Partials      699     699
Flag Coverage Δ
#smoketests 50.52% <ø> (ø) ⬆️
#unittests 65.05% <ø> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/fsl/dti.py 66.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea4f1b...8122da0. Read the comment docs.

@mgxd mgxd merged commit a7ab541 into nipy:master Jul 13, 2018
@mgxd mgxd added this to the 1.1.1 milestone Jul 13, 2018
@weningerleon
Copy link
Contributor Author

Thanks for including the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants