[ENH] add -dsort option to TProject

[mattcieslak]

Adds a -dsort option to nipype.interfaces.afni.TProject

[codecov-io]

Codecov Report

Merging #2623 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
- Coverage    67.6%   67.56%   -0.04%     
==========================================
  Files         339      339              
  Lines       42820    42821       +1     
  Branches     5290     5290              
==========================================
- Hits        28948    28932      -16     
- Misses      13189    13207      +18     
+ Partials      683      682       -1

Flag	Coverage Δ
#smoketests	50.76% <ø> (ø)	⬆️
#unittests	65.05% <100%> (-0.04%)	⬇️

Impacted Files	Coverage Δ
nipype/interfaces/afni/preprocess.py	81.53% <100%> (+0.02%)	⬆️
nipype/interfaces/io.py	53.15% <0%> (-1.33%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704b97d...264f0e4. Read the comment docs.

[mgxd]

Thanks for the contribution! I left a comment below - also be sure to run make specs after the changes to update the autotest

[mgxd]

Since multiple -dsort options are allowed, let's allow multiple files.

Here's an example, but you'll want to use InputMultiObject instead of InputMultiPath

nipype/nipype/interfaces/dcm2nii.py

Lines 342 to 344 in 704b97d

	series_numbers = InputMultiPath(
	traits.Str(),
	argstr='-n %s...',

[mattcieslak]

Thanks for pointing out that this can take multiple files! I changed it, checked that it produced a correct command line, and ran make specs. It looks like the test failed while trying to download something.

[mgxd]

LGTM, one last comment - looks like the ci failure is unrelated.

[mgxd]

you can change this to argstr="-dsort %s..." and it'll apply the same behavior you added in _format_arg

[mgxd]

@mattcieslak no worries, we love getting new contributions! the only thing missing is changing dsort's argstr (see above) and removing the _format_arg method

[mgxd]

@mattcieslak this was very close! mind if I reopen?

[mattcieslak]

Should it stay open until 1.1.0? Or should I remove the _format_arg and request another review? Sorry, I'm new to this