Skip to content

fix: avoid closing file descriptors on windows #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2018
Merged

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Jun 12, 2018

Fixes #2616 .

Note that on Windows, you cannot set close_fds to true and also redirect the standard handles by setting stdin, stdout or stderr.

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #2617 into master will increase coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2617      +/-   ##
==========================================
+ Coverage   67.59%   67.59%   +<.01%     
==========================================
  Files         339      339              
  Lines       42814    42820       +6     
  Branches     5288     5290       +2     
==========================================
+ Hits        28941    28946       +5     
+ Misses      13191    13184       -7     
- Partials      682      690       +8
Flag Coverage Δ
#smoketests 50.75% <16.66%> (-0.01%) ⬇️
#unittests 65.06% <16.66%> (-0.03%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base/core.py 89.7% <ø> (ø) ⬆️
nipype/utils/filemanip.py 78.37% <16.66%> (-0.88%) ⬇️
nipype/interfaces/dynamic_slicer.py 17.47% <0%> (ø) ⬆️
nipype/interfaces/nipy/preprocess.py 45.79% <0%> (ø) ⬆️
nipype/interfaces/io.py 54.47% <0%> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.27% <0%> (ø) ⬆️
nipype/pipeline/plugins/multiproc.py 82.14% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5567b...6e33237. Read the comment docs.

@effigies effigies merged commit eae8b20 into nipy:master Jun 16, 2018
@effigies effigies added this to the 1.1.0 milestone Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when running NiftyReg node
4 participants