-
Notifications
You must be signed in to change notification settings - Fork 532
CI: Move PyPI deployment to Circle #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2587 +/- ##
=========================================
+ Coverage 67.27% 67.57% +0.3%
=========================================
Files 335 335
Lines 42612 42612
Branches 5269 5269
=========================================
+ Hits 28669 28797 +128
+ Misses 13228 13134 -94
+ Partials 715 681 -34
Continue to review full report at Codecov.
|
ca19849
to
1cef84f
Compare
This reverts commit d3374eb.
You can set the |
@satra cjmarkie |
@satra mgxd |
@satra Are you good with merging this? |
branches: | ||
ignore: /.*/ | ||
tags: | ||
only: /.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for tags - should we only do master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the goal you're trying to achieve? I assume not to push a package every time master is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i may be misunderstanding how circle bit works - i thought the tags section should look only for tags applied to the master branch, since tags could potentially be applied on any branch. i'll read up on my train ride in a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So by default Circle will build on all branches and no tags. In order to restrict it from some branches, you can match with ignore
and only
, so here I'm saying don't run this on any branches. And then to run on all tags (regardless of branch) we use only: /.*/
.
Which is to say, this job will be run iff we have a tag.
Closes #2313.
Changes proposed in this pull request
The Travis builds are a little weird in that, on tagging, the first to successfully complete will upload to PyPI, while the rest will fail. This seems unnecessary, and we might as well use the dependencies allowed by Circle 2.0 workflows.
This will need @satra's PyPI credentials stored properly in Circle before it makes sense to merge.
Testing everything but the
twine
upload.