Skip to content

fix little out_file bugs in afni.Zcat and afni.Merge #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

salma1601
Copy link
Contributor

little bugs make afni.Zcat and afni.Merge crash when the out_file is kept as default.

@@ -1434,7 +1434,7 @@ class MergeInputSpec(AFNICommandInputSpec):
name_template='%s_merge',
desc='output image file name',
argstr='-prefix %s',
name_source='in_file')
name_source='in_files')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do in the case of multiple files? Use the first file's name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@effigies
Copy link
Member

effigies commented Feb 2, 2018

Looks reasonable.

@effigies effigies merged commit b2c7130 into nipy:master Feb 2, 2018
@effigies effigies added this to the 1.0.1 milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants