Skip to content

FIX: argstr for mask in BlurToFWHM #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Conversation

mvdoc
Copy link
Member

@mvdoc mvdoc commented Jan 30, 2018

Fix argstr for mask input in BlurToFWHM

@effigies
Copy link
Member

This appears to be changing the API, since -blurmaster is a valid argument. It's possible someone depends on this misnaming.

Maybe a compromise is to deprecate mask, add mask_file to correspond to -mask, and a blurmaster_file to replace the old mask.

@mvdoc
Copy link
Member Author

mvdoc commented Jan 30, 2018

I'm not sure I follow, because -blurmaster is another argument already present in the inputspec. Right now if somebody specifies both a blurmaster and a mask, it will fail, because it will be converted as -blurmaster blurmaster.nii.gz -blurmaster mask.nii.gz. Besides, 3dBlurToFWHM would use the smoothness of the mask as target smoothness, and if it's a binary mask that wouldn't work.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. I didn't read the context and thought you were replacing blurmaster with mask. Yes, this looks like a copy-paste job that just forgot to change the argstr.

LGTM.

@effigies effigies merged commit db72d88 into nipy:master Jan 31, 2018
@effigies effigies added this to the 1.0.1 milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants