[ENH] Set maxtasksperchild in MultiProc Pool #2284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the workers to grow too big. Offer one new plugin_args to modify this option.
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
+ Coverage 67.49% 67.49% +<.01%
==========================================
Files 1189 1189
Lines 59151 59156 +5
Branches 8510 8510
==========================================
+ Hits 39922 39927 +5
Misses 18153 18153
Partials 1076 1076
Continue to review full report at Codecov.
|
effigies
approved these changes
Nov 16, 2017
effigies
reviewed
Nov 16, 2017
doc/users/plugins.rst
Outdated
| @@ -82,6 +82,10 @@ Optional arguments:: | |||
| exceed the total amount of resources available (memory and threads), when | |||
| ``False`` (default), only a warning will be issued. | |||
|
|
|||
| maxtasksperchild : refresh the workers after this specific number of nodes | |||
| run (default: 10). | |||
There was a problem hiding this comment.
Actually, this could be clearer. Perhaps: "number of nodes to run on each worker before refreshing (default: 10)."
|
This shouldn't be harmful. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the workers to grow too big. Offer one new plugin_args to modify this option.
Now testing if this alleviates in any ways the memory issues we are experiencing in nipreps/fmriprep#833.