Skip to content

FIX: Typo in BBRegister._list_outputs #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

FIX: Typo in BBRegister._list_outputs #2212

merged 1 commit into from
Oct 6, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 5, 2017

Changes proposed in this pull request

  • Check value of out_lta_file rather than out_fsl_file when setting outputs.out_lta_file

@codecov-io
Copy link

codecov-io commented Oct 5, 2017 •
edited
Loading

Codecov Report

Merging #2212 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2212      +/-   ##
=========================================
+ Coverage   72.29%   72.3%   +<.01%     
=========================================
  Files        1178    1178              
  Lines       58736   58736              
  Branches     8456    8456              
=========================================
+ Hits        42466   42468       +2     
+ Misses      14898   14896       -2     
  Partials     1372    1372
Flag Coverage Δ
#smoketests 72.3% <0%> (ø) ⬆️
#unittests 69.85% <0%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 65.27% <0%> (ø) ⬆️
nipype/pipeline/plugins/multiproc.py 77.94% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4801a4c...43f9db8. Read the comment docs.

oesteban
oesteban approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effigies effigies merged commit 4d08138 into nipy:master Oct 6, 2017
@effigies effigies deleted the fix/bbregister_lta_out branch October 6, 2017 00:08
effigies added a commit to effigies/niworkflows that referenced this pull request Oct 6, 2017
@effigies
PIN: nipy/nipype master branch
335e878 
Includes
 - nipy/nipype#2198
 - nipy/nipype#2200
 - nipy/nipype#2203
 - nipy/nipype#2205
 - nipy/nipype#2208
 - nipy/nipype#2211
 - nipy/nipype#2212
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@effigies @codecov-io @oesteban @satra