Skip to content

[ENH] Update C3D version in nipype/base docker image #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

oesteban
Copy link
Contributor

Since sourceforge is having some hiccups and we were using the outdated 1.0.0 version, this PR updates it to 1.1.0 and pulls it down from OSF, which seems more reliable.

Since sourceforge is having some hiccups and we were using the
outdated 1.0.0 version, this PR updates it to 1.1.0 and pulls it
down from OSF, which seems more reliable.
@effigies
Copy link
Member

Is this newer than Neurodebian's convert3d package?

convert3d:
  Installed: (none)
  Candidate: 0.0.20170606-1~pre1~nd16.04+1
  Version table:
     0.0.20170606-1~pre1~nd16.04+1 500
        500 http://neuro.debian.net/debian xenial/main amd64 Packages

It's unclear what that version string corresponds to.

@oesteban
Copy link
Contributor Author

How can we confirm this, @yarikoptic ?

@codecov-io
Copy link

Codecov Report

Merging #2199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files        1174     1174           
  Lines       58738    58738           
  Branches     8454     8454           
=======================================
  Hits        42453    42453           
  Misses      14924    14924           
  Partials     1361     1361
Flag Coverage Δ
#smoketests 72.27% <ø> (ø) ⬆️
#unittests 69.94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b857fa...085dff9. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #2199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files        1174     1174           
  Lines       58738    58738           
  Branches     8454     8454           
=======================================
  Hits        42453    42453           
  Misses      14924    14924           
  Partials     1361     1361
Flag Coverage Δ
#smoketests 72.27% <ø> (ø) ⬆️
#unittests 69.94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b857fa...085dff9. Read the comment docs.

@oesteban
Copy link
Contributor Author

Should we merge in for now while we confirm the fitness of neurodebian's version? @effigies @satra

@effigies
Copy link
Member

effigies commented Sep 26, 2017 via email

@oesteban oesteban merged commit 2f422f0 into nipy:master Sep 27, 2017
@oesteban oesteban deleted the fix/Docker-update-c3d branch September 27, 2017 00:32
@satra
Copy link
Member

satra commented Sep 27, 2017

@oesteban - just a note here that all of this will be driven through neurodocker as soon as jakub sends his PR - which should be sometime this week or early next week.

@oesteban
Copy link
Contributor Author

nice!

@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants