-
Notifications
You must be signed in to change notification settings - Fork 532
[ENH] Update C3D version in nipype/base docker image #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since sourceforge is having some hiccups and we were using the outdated 1.0.0 version, this PR updates it to 1.1.0 and pulls it down from OSF, which seems more reliable.
Is this newer than Neurodebian's
It's unclear what that version string corresponds to. |
How can we confirm this, @yarikoptic ? |
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 1174 1174
Lines 58738 58738
Branches 8454 8454
=======================================
Hits 42453 42453
Misses 14924 14924
Partials 1361 1361
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 72.27% 72.27%
=======================================
Files 1174 1174
Lines 58738 58738
Branches 8454 8454
=======================================
Hits 42453 42453
Misses 14924 14924
Partials 1361 1361
Continue to review full report at Codecov.
|
Okay by me.
…On Sep 26, 2017 7:42 PM, "Oscar Esteban" ***@***.***> wrote:
Should we merge in for now while we confirm the fitness of neurodebian's
version? @effigies <https://github.com/effigies> @satra
<https://github.com/satra>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2199 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8oP01oXrCVrdR6gufjUuDTxK57UOks5smYvjgaJpZM4PkqY8>
.
|
@oesteban - just a note here that all of this will be driven through neurodocker as soon as jakub sends his PR - which should be sometime this week or early next week. |
nice! |
Since sourceforge is having some hiccups and we were using the outdated 1.0.0 version, this PR updates it to 1.1.0 and pulls it down from OSF, which seems more reliable.