-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: --out_itk option for LTAConvert #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
- Coverage 72.25% 72.24% -0.02%
==========================================
Files 1168 1168
Lines 58405 58408 +3
Branches 8400 8400
==========================================
- Hits 42203 42199 -4
- Misses 14868 14871 +3
- Partials 1334 1338 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Actually, would you mind adding
|
No. Just added it. |
xor=('in_lta', 'in_fsl', 'in_mni', 'in_reg', 'in_niftyreg'), | ||
xor=('in_lta', 'in_fsl', 'in_mni', 'in_reg', 'in_niftyreg', 'in_itk'), | ||
), | ||
in_reg=dict(argstr='--initk %s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in_itk
. This file really shouldn't be edited by hand; run make specs
and add the changes. (make specs
does modify other files, so only commit the ones with changes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Sorry, should have seen the comment on the first line. This kind of stuff is a bit new to me. :)
Freesurfer's lta_convert can also convert to the ITK-format used by ANTS. This can be quite handy, for example when you have a small FOV and want to init a ANTS-registration based on a manual transform made with Freesurfer's Freeview.
This pull extends 69a59a9 by @effigies: bby a few lines, so you can also use out_itk.