Skip to content

ENH: --out_itk option for LTAConvert #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 7, 2017
Merged

Conversation

Gilles86
Copy link
Contributor

@Gilles86 Gilles86 commented Sep 4, 2017

Freesurfer's lta_convert can also convert to the ITK-format used by ANTS. This can be quite handy, for example when you have a small FOV and want to init a ANTS-registration based on a manual transform made with Freesurfer's Freeview.

This pull extends 69a59a9 by @effigies: bby a few lines, so you can also use out_itk.

Gilles86 added a commit to VU-Cog-Sci/hires_ODC_7T that referenced this pull request Sep 4, 2017
@codecov-io
Copy link

codecov-io commented Sep 4, 2017

Codecov Report

Merging #2176 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
- Coverage   72.25%   72.24%   -0.02%     
==========================================
  Files        1168     1168              
  Lines       58405    58408       +3     
  Branches     8400     8400              
==========================================
- Hits        42203    42199       -4     
- Misses      14868    14871       +3     
- Partials     1334     1338       +4
Flag Coverage Δ
#smoketests 72.24% <100%> (-0.02%) ⬇️
#unittests 69.91% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...nterfaces/freesurfer/tests/test_auto_LTAConvert.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/freesurfer/utils.py 63.54% <100%> (+0.08%) ⬆️
nipype/utils/filemanip.py 83.22% <0%> (-1.68%) ⬇️
nipype/interfaces/base.py 83.3% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e724c...8495a87. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@effigies
Copy link
Member

effigies commented Sep 7, 2017

Actually, would you mind adding --initk, as well? Doc line:

	--initk <initk.txt>
		input ITK transform (inverse LPS2LPS). Convert ANTS .mat 
		binary to ITK format with ConvertTransformFile (in ANTS).

@Gilles86
Copy link
Contributor Author

Gilles86 commented Sep 7, 2017

No. Just added it.

xor=('in_lta', 'in_fsl', 'in_mni', 'in_reg', 'in_niftyreg'),
xor=('in_lta', 'in_fsl', 'in_mni', 'in_reg', 'in_niftyreg', 'in_itk'),
),
in_reg=dict(argstr='--initk %s',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in_itk. This file really shouldn't be edited by hand; run make specs and add the changes. (make specs does modify other files, so only commit the ones with changes.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Sorry, should have seen the comment on the first line. This kind of stuff is a bit new to me. :)

@effigies effigies merged commit 9abafec into nipy:master Sep 7, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants