FIX: Detecting and apropriately warning about unconnected duplicatlely nodes #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheChymera
force-pushed
the
checks
branch
2 times, most recently
from
e54f020 to
0af73d0
Compare
|
Could you write a unit test for this? That'd be very much appreciated :) |
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
- Coverage 72.25% 72.25% -0.01%
==========================================
Files 1168 1168
Lines 58405 58409 +4
Branches 8400 8400
==========================================
Hits 42203 42203
- Misses 14868 14872 +4
Partials 1334 1334
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
+ Coverage 72.25% 72.26% +<.01%
==========================================
Files 1168 1169 +1
Lines 58405 58429 +24
Branches 8400 8400
==========================================
+ Hits 42203 42221 +18
- Misses 14868 14873 +5
- Partials 1334 1335 +1
Continue to review full report at Codecov.
|
|
@oesteban added :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the workflow contained an unconnected node with a duplicate name, the check failed with a nondescript
IndexError, which required the user to either manually re-check their entire connections list for any errors at all, or hack the nipype code with print calls to find out which node is triggering the exception.Now, the check gives the correct name duplication error and the name of the node, even if the node has no lineage.