FIX: allow grabbing a single file (fix bug assuming string is not ite… #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 1158 1158
Lines 58032 58032
Branches 8336 8336
=======================================
Hits 41895 41895
Misses 14815 14815
Partials 1322 1322
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
S3DataGrabberdue to the assumption that Python strings are not iterable (they are) as outlined in nipype.interfaces.io. As a consequence, when you only want to grab a single file from S3, it will cause the interface to loop over the characters of the string specifying the S3-path and subsequently break when trying to download the file. I replaced thehasattr(val, '__iter__')with:isinstance(val, (list, tuple, set))which now allows for grabbing of a single file.