Skip to content

[ENH]: Add AFNI 3dDeconvolve/3dREMLfit interfaces #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 24, 2017

Conversation

rmarkello
Copy link
Collaborator

Changes proposed in this pull request:

  • Add interfaces for AFNI 3dDeconvolve and 3dREMLfit
  • Modify AFNI Command class to add _gen_fname(), lifted from FSL Command class
  • Change outputtype_to_ext method to match FSL convention (output_type_to_ext)

rmarkello and others added 11 commits June 23, 2017 23:41
Added outline of classes for AFNI's 3dDeconvolve (inputspec, outputspec, and
command). Nothing is there yet, but it's something to build off of.
Added options to Deconvolve InputSpec, updated __init__.py with Deconvolve,
and fixed doctests.
Added auto_test files from make spec for AFNI interface model.py
Beefed up AFNICommand Base to include _gen_fname() method (lifted from
FSLCommand Base class). Minor bug edits in Deconvolve cmdline code.
Issue with single quotes around Deconvolve doctest
Forgot to re-run make spec after Deconvolve doctest update
@codecov-io
Copy link

Codecov Report

Merging #2095 into master will decrease coverage by <.01%.
The diff coverage is 72.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   72.14%   72.14%   -0.01%     
==========================================
  Files        1139     1142       +3     
  Lines       57310    57448     +138     
  Branches     8215     8235      +20     
==========================================
+ Hits        41344    41443      +99     
- Misses      14673    14706      +33     
- Partials     1293     1299       +6
Flag Coverage Δ
#smoketests 72.14% <72.14%> (-0.01%) ⬇️
#unittests 69.75% <72.14%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/afni/__init__.py 100% <100%> (ø) ⬆️
nipype/interfaces/afni/base.py 51.75% <15.78%> (-8.04%) ⬇️
nipype/interfaces/afni/model.py 79.34% <79.34%> (ø)
nipype/interfaces/afni/tests/test_auto_Remlfit.py 85.71% <85.71%> (ø)
...pype/interfaces/afni/tests/test_auto_Deconvolve.py 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a11f0...44c4dd1. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2095 into master will decrease coverage by <.01%.
The diff coverage is 72.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   72.14%   72.14%   -0.01%     
==========================================
  Files        1139     1142       +3     
  Lines       57310    57448     +138     
  Branches     8215     8235      +20     
==========================================
+ Hits        41344    41443      +99     
- Misses      14673    14706      +33     
- Partials     1293     1299       +6
Flag Coverage Δ
#smoketests 72.14% <72.14%> (-0.01%) ⬇️
#unittests 69.75% <72.14%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/afni/__init__.py 100% <100%> (ø) ⬆️
nipype/interfaces/afni/base.py 51.75% <15.78%> (-8.04%) ⬇️
nipype/interfaces/afni/model.py 79.34% <79.34%> (ø)
...pype/interfaces/afni/tests/test_auto_Deconvolve.py 85.71% <85.71%> (ø)
nipype/interfaces/afni/tests/test_auto_Remlfit.py 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a11f0...44c4dd1. Read the comment docs.

@satra satra merged commit ac050de into nipy:master Jun 24, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants