-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: Enable antsRegistration 2.2.0+ masking #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Turns out I failed to hook up these inputs, so the downstream testing I was doing was worthless. Added a doctest, which found another bug. Ready for review. |
It turns out this is a post 2.1.0 development... Reverting #2070 and will update the input spec accordingly. |
72181cb
to
90d1d35
Compare
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
- Coverage 72.16% 72.13% -0.03%
==========================================
Files 1138 1138
Lines 57229 57268 +39
Branches 8199 8206 +7
==========================================
+ Hits 41301 41313 +12
- Misses 14638 14663 +25
- Partials 1290 1292 +2
Continue to review full report at Codecov.
|
Status: I can run the desired command in ANTs 2.1.0 (though it crashes; it seems they changed how they did masking). I'm upgrading our setup to ANTs 2.2.0, so I'll be able to test it today. |
Status: I'm able to use this to pass a mask in ANTs 2.1.0; I'll test with 2.2.0 today. |
@effigies - for nipype containers, we should move over to neurodebian install for ants to minimize footprint, now that the latest version is available there. |
@satra Done. |
Changes proposed in this pull request
fixed
/moving_image_masks
input spec entries, mutually exclusive with the singular versionsmin_ver=2.2.0
max_ver=2.1.0
; they produce different command-linesAntsCommand
is given a usableversion
property, based on runningantsRegistration --version
Old PR text, for context.
Changes proposed in this pull request
Bug introduced in #2070.