Skip to content

fix: do not create a nipype folder in the home directory by default #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2017

Conversation

satra
Copy link
Member

@satra satra commented Jun 14, 2017

Changes proposed in this pull request

  • Nipype by default should be stateless and not create any change outside of the directory it is called from.

@oesteban
Copy link
Contributor

We probably should also provide a system-wide way to configure settings, a la matplotlib and do not use the ~/.nipype anymore. WDYT?

@satra
Copy link
Member Author

satra commented Jun 14, 2017

people can still use that location, just that we don't create it by default. the default config is the one that comes from the library.

@oesteban
Copy link
Contributor

Yes -- the idea is to limit the config sources:

  • Installation wide (like matplotlib, under nipype installation folder in pythonpath)
  • Run-wide: at the working directory level.

@satra
Copy link
Member Author

satra commented Jun 14, 2017

@oesteban - we have always had that. three locations: (in the nipype code, ~/.nipype, cwd).

however, after this PR, it will not write a file by default in ~/.nipype. but in all cases, local always supersedes the other two.

…-creation

* upstream/master:
  CI: Push nipype/base:latest on release
  Remove APT version pins
  Update AFNI pin to current NeuroDebian package
@codecov-io
Copy link

Codecov Report

Merging #2076 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   72.17%   72.16%   -0.01%     
==========================================
  Files        1138     1138              
  Lines       57233    57229       -4     
  Branches     8199     8199              
==========================================
- Hits        41306    41299       -7     
- Misses      14637    14640       +3     
  Partials     1290     1290
Flag Coverage Δ
#smoketests 72.16% <50%> (-0.01%) ⬇️
#unittests 69.77% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/utils/config.py 62.22% <50%> (-4.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2744d4c...2f23f44. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2076 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   72.17%   72.16%   -0.01%     
==========================================
  Files        1138     1138              
  Lines       57233    57229       -4     
  Branches     8199     8199              
==========================================
- Hits        41306    41299       -7     
- Misses      14637    14640       +3     
  Partials     1290     1290
Flag Coverage Δ
#smoketests 72.16% <50%> (-0.01%) ⬇️
#unittests 69.77% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/utils/config.py 62.22% <50%> (-4.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2744d4c...2f23f44. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2076 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   72.17%   72.16%   -0.01%     
==========================================
  Files        1138     1138              
  Lines       57233    57229       -4     
  Branches     8199     8199              
==========================================
- Hits        41306    41299       -7     
- Misses      14637    14640       +3     
  Partials     1290     1290
Flag Coverage Δ
#smoketests 72.16% <50%> (-0.01%) ⬇️
#unittests 69.77% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/utils/config.py 62.22% <50%> (-4.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2744d4c...2f23f44. Read the comment docs.

@satra satra merged commit b5d83d4 into nipy:master Jun 15, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
@satra satra deleted the fix/remove-config-creation branch October 30, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants