Replace deprecated HasTraits.set with trait_set #2048
Conversation
|
Cleaned up some simple nibabel-related warnings. |
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 72.17% 72.17% +<.01%
==========================================
Files 1134 1134
Lines 57098 57096 -2
Branches 8179 8179
==========================================
Hits 41208 41208
+ Misses 14604 14602 -2
Partials 1286 1286
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 72.17% 72.17% +<.01%
==========================================
Files 1134 1134
Lines 57098 57096 -2
Branches 8179 8179
==========================================
Hits 41208 41208
+ Misses 14604 14602 -2
Partials 1286 1286
Continue to review full report at Codecov.
|
| @@ -1,4 +1,6 @@ | |||
| machine: | |||
| pre: | |||
| - curl -sSL https://s3.amazonaws.com/circle-downloads/install-circleci-docker.sh | bash -s -- 1.10.0 | |||
There was a problem hiding this comment.
This would break the cache (if it worked with 1.9, we didn't get it to work, right @satra?). Caching does not work with 1.10.
There was a problem hiding this comment.
sth weird happened with docker. i thought i had removed 1.9 and caching worked, but not after it got merged. we still have to revisit the cache situation. from a time perspective restoring and saving the cache takes almost as time as building it.
There was a problem hiding this comment.
yes, we should probably roll back to the docker pull solution, and manually update nipype/base
There was a problem hiding this comment.
(I don't have hopes for getting the cache to work. Definitely not with 1.10 but 1.9 neither)
Tests are currently failing, I think at least partially because of a bunch of deprecation warnings about
HasTraits.set.This fixes that (I think). Then hopefully the logs will be clear enough to identify other issues.