Skip to content

FIX hdr_copy in niftyseg BinaryMaths interface #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2017
Merged

FIX hdr_copy in niftyseg BinaryMaths interface #2036

merged 2 commits into from
May 19, 2017

Conversation

byvernault
Copy link
Contributor

Fixes hdr_copy in niftyseg BinaryMaths interface in the _overload_extensions fct.

Changes proposed in this pull request

  • the overload function for the operation hdr_copy was using the wrong path to set the output file
  • changing the path to the path from the value arguments instead of the path given by the super()._overload_extension

Sorry for the mistake here. I didn't realise we were using the wrong path.

Kind Regards,
Ben

@codecov-io
Copy link

Codecov Report

Merging #2036 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
- Coverage   72.19%   72.19%   -0.01%     
==========================================
  Files        1132     1132              
  Lines       57032    57032              
  Branches     8167     8167              
==========================================
- Hits        41175    41174       -1     
- Misses      14572    14573       +1     
  Partials     1285     1285
Flag Coverage Δ
#smoketests 72.19% <33.33%> (-0.01%) ⬇️
#unittests 69.79% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/niftyseg/maths.py 77.77% <33.33%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda3fdc...c79b7fb. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2036 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
- Coverage   72.19%   72.19%   -0.01%     
==========================================
  Files        1132     1132              
  Lines       57032    57032              
  Branches     8167     8167              
==========================================
- Hits        41175    41174       -1     
- Misses      14572    14573       +1     
  Partials     1285     1285
Flag Coverage Δ
#smoketests 72.19% <33.33%> (-0.01%) ⬇️
#unittests 69.79% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/niftyseg/maths.py 77.77% <33.33%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda3fdc...c79b7fb. Read the comment docs.

@satra satra merged commit db825da into nipy:master May 19, 2017
@mmodat mmodat deleted the fix-hdr-copy branch May 19, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants