Skip to content

fix+enh: support for Bayesian spm.ModelEstimate, add write_residuals for Classical #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2017

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented May 17, 2017

Fixes #2029 + #1786 .

Changes proposed in this pull request

  • FIX: inputs.flags is now a dictionary and works as intended
  • ENH: inputs.write_residuals is a boolean that will write create an image for each residual
  • ENH: supports Bayesian estimation outputs

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #2030 into master will decrease coverage by <.01%.
The diff coverage is 74.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   72.19%   72.19%   -0.01%     
==========================================
  Files        1132     1132              
  Lines       57032    57037       +5     
  Branches     8167     8172       +5     
==========================================
+ Hits        41175    41176       +1     
- Misses      14572    14576       +4     
  Partials     1285     1285
Flag Coverage Δ
#smoketests 72.19% <74.28%> (-0.01%) ⬇️
#unittests 69.79% <40%> (ø) ⬆️
Impacted Files Coverage Δ
...pe/interfaces/spm/tests/test_auto_EstimateModel.py 85.71% <100%> (ø) ⬆️
nipype/interfaces/spm/model.py 71.11% <73.52%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda3fdc...f6c2195. Read the comment docs.

@mgxd
Copy link
Member Author

mgxd commented May 18, 2017

not ready for merge yet - addressing #1786 also

EDIT: all set.

@mgxd mgxd changed the title fix+enh: now supply custom flags + write_residuals fix+enh: support for Bayesian spm.ModelEstimate, add write_residuals for Classical May 19, 2017
@satra satra merged commit a06fa8a into nipy:master May 19, 2017
@mgxd mgxd deleted the enh/estmodel branch May 19, 2017 22:46
@mgxd mgxd removed the needs-review label May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants