Skip to content

[ENH] Revise CircleCI settings #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

oesteban
Copy link
Contributor

Changes proposed in this pull request

  • Try to build nipype/base in circle build, and cache it properly.

oesteban added a commit to oesteban/nipype that referenced this pull request May 15, 2017
- Replaces the full installation of FS by a minimized version by @satra
- Depends on nipy#2022
@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #2022 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
+ Coverage   72.19%   72.19%   +<.01%     
==========================================
  Files        1132     1132              
  Lines       57032    57032              
  Branches     8167     8167              
==========================================
+ Hits        41175    41177       +2     
+ Misses      14572    14570       -2     
  Partials     1285     1285
Flag Coverage Δ
#smoketests 72.19% <ø> (ø) ⬆️
#unittests 69.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/base.py 83.96% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda3fdc...65c71f6. Read the comment docs.

@oesteban
Copy link
Contributor Author

Submitted rebuild to see if caching starts working

@satra
Copy link
Member

satra commented May 17, 2017

@oesteban - should this be merged?

@oesteban
Copy link
Contributor Author

@satra I'm trying to see the caching working. But no luck so far. I tried splitting the cached files, so that they are smaller. Maybe that way circle would swallow them. But I don't see any changes.

Let me trigger another build. I'll enable ssh and see if the files are there.

@satra
Copy link
Member

satra commented May 17, 2017

@oesteban - sounds good. you could also check the total size of the cache after it's created, and we can talk to the circle folks to see if the size is the limitation.

@satra
Copy link
Member

satra commented May 18, 2017

@oesteban - did this work?

@oesteban
Copy link
Contributor Author

Yes, the largest tarred image is 8.5 GB. I think we can gzip it. Splitting the images was not a good idea, I just expands the tar file for each single image.

@satra
Copy link
Member

satra commented May 18, 2017

ok i'm testing the gzipped version in the other PR.

@oesteban
Copy link
Contributor Author

oesteban commented May 18, 2017

Altogether, the tar (no compression) makes 12GB

EDIT: with compression 5.5GB

@oesteban
Copy link
Contributor Author

I close this, follow up in #2017

@oesteban oesteban closed this May 18, 2017
@oesteban oesteban deleted the circle/revise-settings branch May 18, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants