Skip to content

FIX: ?h.white is actually created in the -pial step #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2017

Conversation

effigies
Copy link
Member

In this installment of my never-ending series of minor tweaks to ReconAll, I've stumbled across the most annoyingly undocumented (outside of source code) change in process in FreeSurfer v6.0, which is that ?h.white are created in the -pial step, to take advantage of post-aparc refinements. If you happen to kill a process running -pial after the other outputs are produced but before ?h.white is produced, rerunning will incorrectly skip over this step.

I can't guarantee this is the last PR of the series, but I sincerely hope so.

Related: #1991 #1824 #1790

@satra
Copy link
Member

satra commented May 14, 2017

@effigies - this is the reprozip trace of recon-all.

https://www.dropbox.com/s/1w7zjz22v1tuyrm/config.yml?dl=0

using this you should be able to create the graph of recon-all with reprozip (it has a graph generation tool). in the future we hope to create a reprozip to nipype workflow tool, but we need to understand the graph a bit better first.

@effigies
Copy link
Member Author

Ha. I was going to say, I'm nearly ready to start hacking on the reprozip workflow generator just to be done with all of these. Maybe next Thursday?

@satra
Copy link
Member

satra commented May 15, 2017

should this be added in for 0.13.1?

@effigies
Copy link
Member Author

effigies commented May 15, 2017 via email

@satra satra merged commit 4ace7df into nipy:master May 16, 2017
@effigies effigies deleted the fix/recon_steps branch May 16, 2017 12:50
@codecov-io
Copy link

Codecov Report

Merging #2020 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2020   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files        1132     1132           
  Lines       57012    57012           
  Branches     8162     8162           
=======================================
  Hits        41161    41161           
  Misses      14567    14567           
  Partials     1284     1284
Flag Coverage Δ
#smoketests 72.19% <ø> (ø) ⬆️
#unittests 69.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 65.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4358fe5...ceb80d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants