Skip to content

[ENH] Enable num_threads for antsAffineInitializer #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2017

Conversation

oesteban
Copy link
Contributor

This PR just enables the general control for number of threads for
this tool. I just learned that it works differently depending on it
ANTsX/ANTs#444

This PR just enables the general control for number of threads for
this tool. I just learned that it works differently depending on it
ANTsX/ANTs#444
@codecov-io
Copy link

codecov-io commented May 12, 2017

Codecov Report

Merging #2010 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   72.18%   72.19%   +<.01%     
==========================================
  Files        1132     1132              
  Lines       57008    57008              
  Branches     8162     8162              
==========================================
+ Hits        41152    41157       +5     
+ Misses      14572    14567       -5     
  Partials     1284     1284
Flag Coverage Δ
#smoketests 72.19% <100%> (ø) ⬆️
#unittests 69.78% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...terfaces/ants/tests/test_auto_AffineInitializer.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/ants/utils.py 85.71% <100%> (ø) ⬆️
nipype/interfaces/utility/wrappers.py 86.36% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec86b74...f82d4c8. Read the comment docs.

@satra
Copy link
Member

satra commented May 12, 2017

@oesteban - this likely needs a make specs update.

@oesteban
Copy link
Contributor Author

You got it. Felt like a newbie when I read your comment :P

@satra
Copy link
Member

satra commented May 12, 2017

@oesteban - we will address this before 1.0. better testing is coming to nipype (https://github.com/kaczmarj/neurodocker).

@oesteban
Copy link
Contributor Author

Rerun the failing builds of Travis (due to apt's hiccups). This is ready to merge.

@satra satra merged commit a34d50f into nipy:master May 16, 2017
@oesteban oesteban deleted the enh/AntsAffineInitializerThreads branch November 29, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants