Skip to content

fix: renamed mask_file to mask_files #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Apr 30, 2017

removes support for CompCor input mask_file - closes #1982

@chrisgorgo
Copy link
Member

@satra
Copy link
Member

satra commented Apr 30, 2017

hold off on merging, i'm cleaning up the code.

@codecov-io
Copy link

Codecov Report

Merging #1984 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
- Coverage   72.29%   72.29%   -0.01%     
==========================================
  Files        1089     1089              
  Lines       55583    55582       -1     
  Branches     8009     8009              
==========================================
- Hits        40182    40181       -1     
- Misses      14137    14147      +10     
+ Partials     1264     1254      -10
Flag Coverage Δ
#smoketests 72.29% <0%> (-0.01%) ⬇️
#unittests 69.81% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/algorithms/confounds.py 74.59% <0%> (-0.06%) ⬇️
nipype/workflows/fmri/fsl/preprocess.py 87.96% <0%> (ø) ⬆️
nipype/sphinxext/plot_workflow.py 13.29% <0%> (ø) ⬆️
nipype/interfaces/spm/model.py 71.74% <0%> (ø) ⬆️
nipype/interfaces/spm/preprocess.py 68.93% <0%> (ø) ⬆️
nipype/workflows/dmri/fsl/artifacts.py 81.28% <0%> (ø) ⬆️
nipype/interfaces/fsl/base.py 84.04% <0%> (ø) ⬆️
nipype/testing/decorators.py 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82a18f...2f76fbb. Read the comment docs.

@satra satra mentioned this pull request May 2, 2017
@satra
Copy link
Member

satra commented May 3, 2017

closing this for #1992

@satra satra closed this May 3, 2017
@mgxd mgxd deleted the fix/compcormask branch May 18, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompCor issues
4 participants