-
Notifications
You must be signed in to change notification settings - Fork 532
[FIX] Ensure build fails in Circle when tests fail #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added a dummy test that always fails
DO NOT MERGE UNTIL THE WIP FLAG IS REMOVED FROM THE TITLE. Thanks!! |
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
==========================================
+ Coverage 72.24% 72.31% +0.07%
==========================================
Files 1088 1089 +1
Lines 55527 55559 +32
Branches 7994 7994
==========================================
+ Hits 40116 40180 +64
+ Misses 14145 14115 -30
+ Partials 1266 1264 -2
Continue to review full report at Codecov.
|
this is ready to merge 👍 |
I'm fixing the documentation building: there is some indentation error in the confounds module. Once I fix that, I'll merge master in. |
Ok, building the docs with docker in my desktop works fine now. Also merged with master. Let's see if Circle goes through. If so this is finally ready. |
The segmentation fault is happening in another place (or it is different):
|
(ref #1933)