Skip to content

[FIX] Ensure build fails in Circle when tests fail #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2017

Conversation

oesteban
Copy link
Contributor

(ref #1933)

  • Added a dummy test that always fails

@oesteban oesteban changed the title [FIX] Ensure build fails in Circle when tests fail [WIP/FIX] Ensure build fails in Circle when tests fail Apr 29, 2017
@oesteban
Copy link
Contributor Author

DO NOT MERGE UNTIL THE WIP FLAG IS REMOVED FROM THE TITLE.

Thanks!!

@codecov-io
Copy link

codecov-io commented Apr 29, 2017

Codecov Report

Merging #1981 into master will increase coverage by 0.07%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage   72.24%   72.31%   +0.07%     
==========================================
  Files        1088     1089       +1     
  Lines       55527    55559      +32     
  Branches     7994     7994              
==========================================
+ Hits        40116    40180      +64     
+ Misses      14145    14115      -30     
+ Partials     1266     1264       -2
Flag Coverage Δ
#smoketests 72.31% <93.54%> (+0.07%) ⬆️
#unittests 69.84% <93.54%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/tests/test_nipype.py 75% <ø> (ø) ⬆️
nipype/workflows/smri/niftyreg/groupwise.py 8% <100%> (ø) ⬆️
nipype/algorithms/confounds.py 74.65% <93.33%> (ø) ⬆️
examples/test_spm.py 87.5% <0%> (ø)
nipype/interfaces/fsl/utils.py 72.73% <0%> (+0.11%) ⬆️
nipype/interfaces/io.py 52.84% <0%> (+0.32%) ⬆️
nipype/algorithms/misc.py 44.22% <0%> (+1.38%) ⬆️
nipype/interfaces/spm/preprocess.py 68.93% <0%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26b3de...8d530d3. Read the comment docs.

@oesteban oesteban changed the title [WIP/FIX] Ensure build fails in Circle when tests fail [FIX] Ensure build fails in Circle when tests fail Apr 29, 2017
@oesteban
Copy link
Contributor Author

this is ready to merge 👍

@oesteban oesteban requested a review from satra April 29, 2017 10:17
@satra
Copy link
Member

satra commented Apr 29, 2017

@oesteban - i merged #1977, so let's merge that with this and then create the fix.

@oesteban
Copy link
Contributor Author

I'm fixing the documentation building: there is some indentation error in the confounds module. Once I fix that, I'll merge master in.

@oesteban
Copy link
Contributor Author

Ok, building the docs with docker in my desktop works fine now. Also merged with master. Let's see if Circle goes through. If so this is finally ready.

@oesteban
Copy link
Contributor Author

The segmentation fault is happening in another place (or it is different):

nipype/pipeline/plugins/tests/test_callback.py::test_callback_multiproc_normal /home/travis/.travis/job_stages: line 53:  6712 Segmentation fault      (core dumped) py.test -v --doctest-modules nipype

@oesteban oesteban requested a review from chrisgorgo April 29, 2017 23:33
@satra satra merged commit f66a5a6 into nipy:master Apr 30, 2017
@oesteban oesteban deleted the fix/1933 branch April 30, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants