small edit of the MCFLIRT tests #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
=========================================
- Coverage 72.6% 72.51% -0.1%
=========================================
Files 1070 1063 -7
Lines 54456 54211 -245
Branches 7868 7823 -45
=========================================
- Hits 39537 39309 -228
+ Misses 13686 13681 -5
+ Partials 1233 1221 -12
Continue to review full report at Codecov.
|
effigies
reviewed
Apr 28, 2017
| @@ -344,6 +350,9 @@ def test_mcflirt(setup_flirt): | |||
|
|
|||
| for name, settings in list(opt_map.items()): | |||
| fnt = fsl.MCFLIRT(in_file=infile, **{name: settings[1]}) | |||
| outfile = os.path.join(os.getcwd(), nme) | |||
| outfile = fnt._gen_fname(outfile, suffix='_mcf') | |||
There was a problem hiding this comment.
Since these are always the same, they could go up under _, nme = os.path.split(infile), rather than be in the loop body.
There was a problem hiding this comment.
the first line could move, but outfile variable name would need to change because the second outfile has to be generated within the loop.
|
Good catch. Sorry about that. Certainly don't hold this up based on that
comment.
…On Apr 28, 2017 6:24 PM, "Satrajit Ghosh" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nipype/interfaces/fsl/tests/test_preprocess.py
<#1979 (comment)>:
> @@ -344,6 +350,9 @@ def test_mcflirt(setup_flirt):
for name, settings in list(opt_map.items()):
fnt = fsl.MCFLIRT(in_file=infile, **{name: settings[1]})
+ outfile = os.path.join(os.getcwd(), nme)
+ outfile = fnt._gen_fname(outfile, suffix='_mcf')
the first line could move, but outfile variable name would need to change
because the second outfile has to be generated within the loop.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1979 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8l0VV5WNdRBoMtx-lKsmG1wssPt6ks5r0mcEgaJpZM4NLNsg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.