Skip to content

Output warp fields and jacobian correction files in TOPUP. #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2017

Conversation

chrisgorgo
Copy link
Member

No description provided.

outputs['out_jacs'] = [os.path.abspath(
self.inputs.out_jac_prefix + "_%02d" % (
i + 1) + Info.output_type_to_ext(self.inputs.output_type)) for i in
range(n_vols)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion for readability:

ext = Info.output_type_to_ext(self.inputs.output_type)
fmt = os.path.abspath('{prefix}_{i:02d}{ext}').format
outputs['out_warps'] = [fmt(prefix=self.inputs.out_warp_prefix, i=i, ext=ext)
                        for i in range(1, n_vols + 1)]
outputs['out_jacs'] = [fmt(prefix=self.inputs.out_jac_prefix, i=i, ext=ext)
                       for i in range(1, n_vols + 1)]

out_jac_prefix = traits.Str("jac", argstr='--jacout=%s',
hash_files=False,
desc='prefix for the warpfield images',
usedefault=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does making these required outputs have the potential to produce large amounts of data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thinks so. Those files will also be automatically deleted if no used.

@codecov-io
Copy link

Codecov Report

Merging #1976 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   72.63%   72.63%   -0.01%     
==========================================
  Files        1070     1070              
  Lines       54407    54417      +10     
  Branches     7857     7860       +3     
==========================================
+ Hits        39517    39524       +7     
- Misses      13659    13662       +3     
  Partials     1231     1231
Flag Coverage Δ
#smoketests 72.63% <50%> (-0.01%) ⬇️
#unittests 70.18% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/tests/test_auto_TOPUP.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/fsl/epi.py 65.06% <50%> (-0.49%) ⬇️
.../interfaces/freesurfer/tests/test_auto_ReconAll.py 100% <0%> (ø) ⬆️
...ype/interfaces/tests/test_auto_FreeSurferSource.py 100% <0%> (ø) ⬆️
nipype/interfaces/io.py 52.55% <0%> (+0.03%) ⬆️
nipype/interfaces/base.py 84.84% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4b08c...4ecd866. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Apr 27, 2017

Codecov Report

Merging #1976 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   72.63%   72.63%   -0.01%     
==========================================
  Files        1070     1070              
  Lines       54407    54417      +10     
  Branches     7857     7860       +3     
==========================================
+ Hits        39517    39524       +7     
- Misses      13659    13662       +3     
  Partials     1231     1231
Flag Coverage Δ
#smoketests 72.63% <50%> (-0.01%) ⬇️
#unittests 70.18% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/tests/test_auto_TOPUP.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/fsl/epi.py 65.06% <50%> (-0.49%) ⬇️
...ype/interfaces/tests/test_auto_FreeSurferSource.py 100% <0%> (ø) ⬆️
.../interfaces/freesurfer/tests/test_auto_ReconAll.py 100% <0%> (ø) ⬆️
nipype/interfaces/io.py 52.55% <0%> (+0.03%) ⬆️
nipype/interfaces/base.py 84.84% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4b08c...4ecd866. Read the comment docs.

@effigies effigies merged commit ca30015 into nipy:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants