Skip to content

ENH: Find graymid/midthickness surfs #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

effigies
Copy link
Member

Surfaces halfway between the pial surface and white/gray boundary are often called either "graymid" or "midthickness" surfaces, and it's reasonably common for people to create them. A lot of FreeSurfer tools like them to be in the surf folder, so this adds the ability to pull them into FreeSurferSource by either name.

In turn, this allows a workflow to make a decision to create such surfaces based on whether they already exist, which will become especially useful once we get conditional nodes.

It requires a slight refactoring of altkey / _get_files to accept multiple keys, since altkey='*mid*' catches ?h.area.mid.

@codecov-io
Copy link

Codecov Report

Merging #1972 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files        1070     1070              
  Lines       54408    54407       -1     
  Branches     7858     7857       -1     
==========================================
+ Hits        39518    39519       +1     
+ Misses      13659    13657       -2     
  Partials     1231     1231
Flag Coverage Δ
#smoketests 72.63% <100%> (ø) ⬆️
#unittests 70.19% <100%> (ø) ⬆️
Impacted Files Coverage Δ
.../interfaces/freesurfer/tests/test_auto_ReconAll.py 100% <ø> (ø) ⬆️
...ype/interfaces/tests/test_auto_FreeSurferSource.py 100% <ø> (ø) ⬆️
nipype/interfaces/io.py 52.51% <100%> (-0.04%) ⬇️
nipype/interfaces/base.py 84.84% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c23846...5278ba1. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Apr 25, 2017

Codecov Report

Merging #1972 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files        1070     1070              
  Lines       54408    54407       -1     
  Branches     7858     7857       -1     
==========================================
  Hits        39519    39519              
+ Misses      13658    13657       -1     
  Partials     1231     1231
Flag Coverage Δ
#smoketests 72.63% <100%> (ø) ⬆️
#unittests 70.19% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...ype/interfaces/tests/test_auto_FreeSurferSource.py 100% <ø> (ø) ⬆️
.../interfaces/freesurfer/tests/test_auto_ReconAll.py 100% <ø> (ø) ⬆️
nipype/interfaces/io.py 52.51% <100%> (-0.04%) ⬇️
nipype/interfaces/afni/base.py 59.79% <0%> (-1.04%) ⬇️
nipype/interfaces/base.py 84.84% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c23846...5278ba1. Read the comment docs.

@chrisgorgo chrisgorgo merged commit ccd0527 into nipy:master Apr 27, 2017
@effigies effigies deleted the enh/graymid branch April 27, 2017 01:05
@mgxd mgxd removed the needs-review label Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants