Skip to content

FIX: Restore FSVersion to string #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Conversation

effigies
Copy link
Member

#1958 changed FSVersion from a string to a LooseVersion object. This change corrects this issue.

@satra
Copy link
Member

satra commented Apr 20, 2017

@effigies - was this breaking something, if so should there be a test for this to prevent future breakage?

@effigies
Copy link
Member Author

Yes, see nipreps/niworkflows#151.

I'm actually not sure that anybody else would have depended on this, since it's something we added post 0.13.0-rc1, but I also don't want to pull the rug out from anybody who did. It didn't show up in our tests because we don't pin to master, but to specific merge commits. So it was found by a contributor who keeps his nipype bleeding edge.

Test passes locally.

@chrisgorgo chrisgorgo merged commit e1fb595 into nipy:master Apr 21, 2017
@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #1962 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   72.52%   72.52%   +<.01%     
==========================================
  Files        1070     1070              
  Lines       54382    54386       +4     
  Branches     7858     7858              
==========================================
+ Hits        39440    39444       +4     
  Misses      13715    13715              
  Partials     1227     1227
Flag Coverage Δ
#smoketests 72.52% <100%> (ø) ⬆️
#unittests 70.07% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...ype/interfaces/freesurfer/tests/test_preprocess.py 89.61% <100%> (+0.56%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89436c...9b2a444. Read the comment docs.

@effigies effigies deleted the bug/fsversion branch April 21, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants