[ENH] FSL maths interface, add the remaining dimension reduction operations…

[imalone]

A number of the fslmaths -T dimension reduction operations were missing from the interface, this pull request adds support for them: MaxnImage (-Tmaxn), MinImage (-Tmin), MedianImage (-Tmedian), PercentileImage (-Tperc P), AR1Image (-Tar1) and the -X/-Y/-Z forms.

[codecov-io]

Codecov Report

Merging #1956 into master will increase coverage by 0.03%.
The diff coverage is 89.58%.

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage    72.5%   72.53%   +0.03%     
==========================================
  Files        1063     1068       +5     
  Lines       54209    54305      +96     
  Branches     7825     7845      +20     
==========================================
+ Hits        39305    39391      +86     
- Misses      13682    13687       +5     
- Partials     1222     1227       +5

Flag	Coverage Δ
#smoketests	72.53% <89.58%> (+0.03%)	⬆️
#unittests	70.08% <89.58%> (+0.03%)	⬆️

Impacted Files	Coverage Δ
nipype/interfaces/fsl/__init__.py	100% <ø> (ø)	⬆️
nipype/interfaces/fsl/maths.py	99.42% <100%> (+0.1%)	⬆️
.../interfaces/fsl/tests/test_auto_PercentileImage.py	85.71% <85.71%> (ø)
nipype/interfaces/fsl/tests/test_auto_MinImage.py	85.71% <85.71%> (ø)
nipype/interfaces/fsl/tests/test_auto_AR1Image.py	85.71% <85.71%> (ø)
nipype/interfaces/fsl/tests/test_auto_MaxnImage.py	85.71% <85.71%> (ø)
...pype/interfaces/fsl/tests/test_auto_MedianImage.py	85.71% <85.71%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482ac61...1a02111. Read the comment docs.

[satra]

@imalone - this looks good. could you please merge with master and run a make specs on the main directory. it will generate some new auto tests for these interfaces that you can add to this PR.

[imalone]

Thanks.
It wanted to also add or change the following files which I haven't committed as they don't relate to the interfaces I added:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   nipype/interfaces/afni/tests/test_auto_Autobox.py
	modified:   nipype/interfaces/utility/tests/test_auto_Merge.py

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	fsl.patch
	nipype/algorithms/tests/test_auto_CompCor.py
	nipype/algorithms/tests/test_auto_ErrorMap.py
	nipype/algorithms/tests/test_auto_Overlap.py
	nipype/algorithms/tests/test_auto_TSNR.py
	nipype/interfaces/ants/tests/test_auto_KellyKapowski.py
	nipype/interfaces/fsl/tests/test_auto_AccuracyTester.py
	nipype/interfaces/fsl/tests/test_auto_Classifier.py
	nipype/interfaces/fsl/tests/test_auto_Cleaner.py
	nipype/interfaces/fsl/tests/test_auto_FeatureExtractor.py
	nipype/interfaces/fsl/tests/test_auto_Training.py
	nipype/interfaces/fsl/tests/test_auto_TrainingSetCreator.py

[imalone]

I've merged with master on my fork (nipy/master branch actually, as my master is originally a fork of a different fork), but I can't see how I can update this pull request to come from that branch. Surely it's only the target branch that matters at this end anyway?

[satra]

@imalone - this is fine for now - it is the target branch that matters. however, we do like to sync up things from time to time.

[imalone]

Thanks, will try to remember in future, just a bit tricky in this instance.