FIX: catch write_graph errors for 'hierarchical/colored #1944
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
- Coverage 72.49% 72.48% -0.01%
==========================================
Files 1063 1063
Lines 54159 54161 +2
Branches 7811 7812 +1
==========================================
Hits 39260 39260
- Misses 13680 13681 +1
- Partials 1219 1220 +1
Continue to review full report at Codecov.
|
| @@ -425,6 +425,9 @@ def write_graph(self, dotfilename='graph.dot', graph2use='hierarchical', | |||
| base_dir = os.getcwd() | |||
| base_dir = make_output_dir(base_dir) | |||
| if graph2use in ['hierarchical', 'colored']: | |||
| if self.name[:1].isdigit(): # these graphs break if int | |||
| raise ValueError('{} graph failed, workflow name cannot begin ' | |||
| 'with a number'.format(graph2use)) | |||
There was a problem hiding this comment.
if workflow name cannot begin with a number, shouldn't this be a check when a workflow/node is created/cloned? why is a workflow name check in graph generation?
There was a problem hiding this comment.
@satra the error only occurs when the workflow graph is generated if graph2use is specified as either hierarchical/colored - the other options generate graphs just fine. I'm fine with moving the check to the Workflow initialization if we want to go in that direction - was trying to affect the smallest range of legacy workflows
#1021