fix: closes #1920 to revert to original behavior for input names #1937
Conversation
nipype/interfaces/utility/base.py
Outdated
| no_flatten = traits.Bool(False, usedefault=True, | ||
| desc='append to outlist instead of extending in vstack mode') | ||
| ravel_inputs = traits.Bool(False, usedefault=True, | ||
| desc='ravel inputs with no_flatten is False') |
nipype/interfaces/utility/base.py
Outdated
| if self.inputs.ravel_inputs: | ||
| out.extend(_ravel(value)) | ||
| else: | ||
| out.extend(value) |
There was a problem hiding this comment.
Personal preference (i.e. feel free to disregard):
if self.inputs.ravel_inputs:
value = _ravel(value)
out.extend(value)or
out.extend(_ravel(value) if self.inputs.ravel_inputs else value)
|
@effigies - i pushed a few more changes in the tests - to no longer allow hstack of unitary inputs. |
|
Sounds good. If tests pass, I'm good with this. |
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
+ Coverage 72.47% 72.47% +<.01%
==========================================
Files 1063 1063
Lines 54148 54153 +5
Branches 7811 7811
==========================================
+ Hits 39244 39249 +5
Misses 13684 13684
Partials 1220 1220
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
+ Coverage 72.47% 72.47% +<.01%
==========================================
Files 1063 1063
Lines 54148 54153 +5
Branches 7811 7811
==========================================
+ Hits 39244 39249 +5
Misses 13684 13684
Partials 1220 1220
Continue to review full report at Codecov.
|
No description provided.