Skip to content

[DOC] Add duecredit references for AFNI and FSL. #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 5, 2017
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 2, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 2, 2017

Codecov Report

Merging #1930 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
+ Coverage   72.47%   72.48%   +0.01%     
==========================================
  Files        1063     1063              
  Lines       54148    54154       +6     
  Branches     7811     7811              
==========================================
+ Hits        39244    39255      +11     
+ Misses      13684    13680       -4     
+ Partials     1220     1219       -1
Flag Coverage Δ
#smoketests 72.48% <100%> (+0.01%) ⬆️
#unittests 70.03% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/base.py 84.66% <ø> (+0.45%) ⬆️
nipype/interfaces/fsl/base.py 84.04% <100%> (+0.34%) ⬆️
nipype/interfaces/afni/base.py 59.79% <100%> (+0.84%) ⬆️
nipype/interfaces/afni/utils.py 75.76% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4176856...81367a0. Read the comment docs.

@@ -1387,7 +1387,7 @@ def _get_ram_mb(pid, pyfunc=False):
def get_max_resources_used(pid, mem_mb, num_threads, pyfunc=False):
"""Function to get the RAM and threads usage of a process

Paramters
Parameters
---------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change: can you add a hyphen so sphinx does not raise a warning?

@@ -157,6 +158,48 @@ class FSLCommand(CommandLine):
input_spec = FSLCommandInputSpec
_output_type = None

references_ = [{'entry': BibTeX('@article{WoolrichJbabdiPatenaudeChappellMakniBehrens'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should place only the Neuroimage 2012 reference at the top level, and then have the specific references with the corresponding interfaces.

@satra
Copy link
Member

satra commented Apr 5, 2017

@tsalo - during the workshop we realized that the afni interfaces need some more tlc. for example 1deval doesn't have a flag -prefix for output. it uses the 1deval ... > out_file option. also outliercount is not using namesource properly and needs an out_file input to work. (while this is not the right PR to fix this, if you know those interfaces, could you please submit a separate PR to fix them?)

@tsalo
Copy link
Member Author

tsalo commented Apr 5, 2017

@satra I can try to fix those problems.

@tsalo
Copy link
Member Author

tsalo commented Apr 5, 2017

@satra And @neuroumbrage, @62442katieb, and @adamkimbler say they'll help!

@satra
Copy link
Member

satra commented Apr 5, 2017

And @neuroumbrage, @62442katieb, and @adamkimbler say they'll help!

awesome!

@oesteban oesteban merged commit 3107a6d into nipy:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants