-
Notifications
You must be signed in to change notification settings - Fork 532
[DOC] Add duecredit references for AFNI and FSL. #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 72.47% 72.48% +0.01%
==========================================
Files 1063 1063
Lines 54148 54154 +6
Branches 7811 7811
==========================================
+ Hits 39244 39255 +11
+ Misses 13684 13680 -4
+ Partials 1220 1219 -1
Continue to review full report at Codecov.
|
nipype/interfaces/base.py
Outdated
@@ -1387,7 +1387,7 @@ def _get_ram_mb(pid, pyfunc=False): | |||
def get_max_resources_used(pid, mem_mb, num_threads, pyfunc=False): | |||
"""Function to get the RAM and threads usage of a process | |||
|
|||
Paramters | |||
Parameters | |||
--------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny change: can you add a hyphen so sphinx does not raise a warning?
nipype/interfaces/fsl/base.py
Outdated
@@ -157,6 +158,48 @@ class FSLCommand(CommandLine): | |||
input_spec = FSLCommandInputSpec | |||
_output_type = None | |||
|
|||
references_ = [{'entry': BibTeX('@article{WoolrichJbabdiPatenaudeChappellMakniBehrens' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should place only the Neuroimage 2012 reference at the top level, and then have the specific references with the corresponding interfaces.
@tsalo - during the workshop we realized that the afni interfaces need some more tlc. for example |
@satra I can try to fix those problems. |
@satra And @neuroumbrage, @62442katieb, and @adamkimbler say they'll help! |
awesome! |
No description provided.