Skip to content

Add 'bold' and 'dti' contrast type to bbregister #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2017

Conversation

chrisgorgo
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 2, 2017

Codecov Report

Merging #1929 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
- Coverage   72.55%   72.54%   -0.01%     
==========================================
  Files        1064     1064              
  Lines       54180    54178       -2     
  Branches     7811     7811              
==========================================
- Hits        39308    39306       -2     
  Misses      13654    13654              
  Partials     1218     1218
Flag Coverage Δ
#smoketests 72.54% <100%> (-0.01%) ⬇️
#unittests 70.01% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 66.7% <100%> (-0.08%) ⬇️
...ype/interfaces/freesurfer/tests/test_BBRegister.py 77.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c444511...70878c2. Read the comment docs.

@effigies
Copy link
Member

effigies commented Apr 2, 2017

$ bbregister --help
[...]
	Contrast Arguments (one required)
	--t1
		Assume t1 contrast, ie, White Matter brighter than Grey Matter
	--t2
		Assume t2 contrast, ie, Gray Matter brighter than White Matter
	--bold
		Same as --t2
	--dti
		Same as --t2

If we're going to add bold, I figure we should add dti; but is there any particular reason to add aliases?

@chrisgorgo chrisgorgo changed the title Add 'bold' contrast type to bbregister Add 'bold' and 'dti' contrast type to bbregister Apr 2, 2017
@chrisgorgo
Copy link
Member Author

You are right it is an alias. I've added 'dti'. It does not hurt to have those and it makes easier for new nipype users accustomed to certain flags.

@effigies effigies merged commit 4176856 into nipy:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants