Split over-eager globs in FreeSurferSource #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltirrell
reviewed
Mar 20, 2017
nipype/interfaces/io.py
Outdated
| inflated = OutputMultiPath( | ||
| File(exists=True), desc='Inflated surface meshes', | ||
| loc='surf') | ||
| pial = OutputMultiPath( | ||
| File(exists=True), desc='Gray matter/pia mater surface meshes', | ||
| File(exists=True), desc='Gray matter/pia matter surface meshes', |
There was a problem hiding this comment.
This (along with lines 1524 and 1527) should stay as pia mater, the name for the innermost membrane surrounding the brain
There was a problem hiding this comment.
Ah, thanks. Fixed. And hopefully gave reasonable descriptions for the other two.
effigies
force-pushed
the
fssource_refine
branch
from
adb9988 to
01eb5c4
Compare
effigies
force-pushed
the
fssource_refine
branch
from
01eb5c4 to
e48be75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't specify
hemi,FreeSurferSourcematches*whiteand*pialfor white matter / pial surfaces, which picks up?h.jacobian_whiteforwhiteand?h.{area,curv}.pialforpial.This restricts the glob prefix for
hemi='both'to?h., and addsjacobian_white,area_pialandcurv_pialentries, which is almost certainly more useful to somebody trying to access any of these entities.