Skip to content

fix: address config parser differences between py2 and 3 #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2017

Conversation

satra
Copy link
Member

@satra satra commented Mar 17, 2017

No description provided.

@satra
Copy link
Member Author

satra commented Mar 17, 2017

this resolves nipype.get_info() errors when the package is installed via pip in the following manner: pip install [--upgrade] https://github.com/nipy/nipype/archive/master.zip

@codecov-io
Copy link

Codecov Report

Merging #1890 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   70.94%   70.94%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       53142    53144       +2     
  Branches     7699     7700       +1     
==========================================
  Hits        37703    37703              
- Misses      14065    14080      +15     
+ Partials     1374     1361      -13
Flag Coverage Δ
#smoketests 43.41% <80%> (ø)
#unittests 70.39% <100%> (-0.01%)
Impacted Files Coverage Δ
nipype/pkg_info.py 84.61% <100%> (+0.83%)
nipype/interfaces/base.py 83.28% <0%> (-0.19%)
nipype/workflows/dmri/fsl/artifacts.py 81.28% <0%> (ø)
nipype/interfaces/fsl/utils.py 65.6% <0%> (ø)
nipype/interfaces/io.py 48.16% <0%> (ø)
nipype/interfaces/fsl/base.py 77.17% <0%> (ø)
nipype/interfaces/spm/model.py 41.76% <0%> (ø)
nipype/utils/docparse.py 53.04% <0%> (ø)
nipype/workflows/fmri/fsl/preprocess.py 72.77% <0%> (ø)
nipype/interfaces/spm/preprocess.py 55.93% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addda24...3967419. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1890 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   70.94%   70.94%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       53142    53144       +2     
  Branches     7699     7700       +1     
==========================================
  Hits        37703    37703              
- Misses      14065    14080      +15     
+ Partials     1374     1361      -13
Flag Coverage Δ
#smoketests 43.41% <80%> (ø)
#unittests 70.39% <100%> (-0.01%)
Impacted Files Coverage Δ
nipype/pkg_info.py 84.61% <100%> (+0.83%)
nipype/interfaces/base.py 83.28% <0%> (-0.19%)
nipype/interfaces/io.py 48.16% <0%> (ø)
nipype/interfaces/fsl/utils.py 65.6% <0%> (ø)
nipype/workflows/fmri/fsl/preprocess.py 72.77% <0%> (ø)
nipype/workflows/dmri/fsl/artifacts.py 81.28% <0%> (ø)
nipype/utils/docparse.py 53.04% <0%> (ø)
nipype/interfaces/spm/preprocess.py 55.93% <0%> (ø)
nipype/interfaces/spm/model.py 41.76% <0%> (ø)
nipype/interfaces/fsl/base.py 77.17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addda24...3967419. Read the comment docs.

@satra satra merged commit 01feb18 into nipy:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants