-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: config option to write crashfiles in plain text #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chrisfilo - you should review this ! |
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
=========================================
- Coverage 73.11% 73.1% -0.02%
=========================================
Files 1061 1061
Lines 53375 53389 +14
=========================================
+ Hits 39025 39029 +4
- Misses 14350 14360 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
=========================================
+ Coverage 70.94% 73% +2.05%
=========================================
Files 1057 1061 +4
Lines 53142 53410 +268
Branches 7699 0 -7699
=========================================
+ Hits 37703 38990 +1287
- Misses 14065 14420 +355
+ Partials 1374 0 -1374
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One thing I would suggest is changing text_crashfiles to crashfile_format = txt | pklz. Also please update the documentation explaining the new option.
Inspired by the eons it took to unpickle the first crash...
also #1184