Skip to content

ENH: config option to write crashfiles in plain text #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2017

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Mar 15, 2017

Inspired by the eons it took to unpickle the first crash...

also #1184

@satra
Copy link
Member

satra commented Mar 15, 2017

@chrisfilo - you should review this !

@codecov-io
Copy link

Codecov Report

Merging #1885 into master will decrease coverage by 0.01%.
The diff coverage is 41.17%.

@@            Coverage Diff            @@
##           master   #1885      +/-   ##
=========================================
- Coverage   73.11%   73.1%   -0.02%     
=========================================
  Files        1061    1061              
  Lines       53375   53389      +14     
=========================================
+ Hits        39025   39029       +4     
- Misses      14350   14360      +10
Flag Coverage Δ
#unittests 73.1% <41.17%> (-0.02%)
Impacted Files Coverage Δ
nipype/utils/config.py 61.7% <ø> (ø)
nipype/pipeline/plugins/tests/test_base.py 100% <ø> (ø)
nipype/utils/filemanip.py 84.75% <11.11%> (-2.43%)
nipype/pipeline/plugins/base.py 65.44% <75%> (-0.07%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1ed4f...b4e6ce4. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #1885 into master will increase coverage by 2.05%.
The diff coverage is 41.17%.

@@            Coverage Diff            @@
##           master   #1885      +/-   ##
=========================================
+ Coverage   70.94%     73%   +2.05%     
=========================================
  Files        1057    1061       +4     
  Lines       53142   53410     +268     
  Branches     7699       0    -7699     
=========================================
+ Hits        37703   38990    +1287     
- Misses      14065   14420     +355     
+ Partials     1374       0    -1374
Flag Coverage Δ
#smoketests ?
#unittests 73% <41.17%> (+2.6%)
Impacted Files Coverage Δ
nipype/utils/config.py 61.7% <ø> (-5.32%)
nipype/pipeline/plugins/tests/test_base.py 100% <ø> (ø)
nipype/utils/filemanip.py 84.39% <11.11%> (-0.59%)
nipype/pipeline/plugins/base.py 65.44% <75%> (+4.15%)
nipype/utils/tests/test_filemanip.py 80.54% <0%> (-12.67%)
nipype/interfaces/spm/base.py 71.37% <0%> (-11.24%)
nipype/utils/provenance.py 67.86% <0%> (-8.2%)
nipype/interfaces/bru2nii.py 66.66% <0%> (-7.41%)
nipype/interfaces/dcm2nii.py 36.71% <0%> (-6.77%)
... and 723 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addda24...fca5ff8. Read the comment docs.

Copy link
Member

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One thing I would suggest is changing text_crashfiles to crashfile_format = txt | pklz. Also please update the documentation explaining the new option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants