enh: allow uses_qform in FLIRT, ApplyXFM interfaces #1875
Conversation
mgxd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
+ Coverage 73.11% 73.11% +<.01%
==========================================
Files 1061 1060 -1
Lines 53375 53373 -2
==========================================
- Hits 39025 39024 -1
+ Misses 14350 14349 -1
Continue to review full report at Codecov.
|
| @@ -561,13 +562,18 @@ def _parse_inputs(self, skip=None): | |||
| if isdefined(self.inputs.save_log) and self.inputs.save_log: | |||
| if not isdefined(self.inputs.verbose) or self.inputs.verbose == 0: | |||
| self.inputs.verbose = 1 | |||
| if isdefined(self.inputs.apply_xfm) and self.inputs.apply_xfm: | |||
| if not self.inputs.in_matrix_file and not self.inputs.uses_qform: | |||
There was a problem hiding this comment.
shouldn't this be if not isdefined(self.inputs.in_matrix_file) and not (isdefined(self.inputs.uses_qform) and not self.inputs.uses_qform)
There was a problem hiding this comment.
is isdefined necessary in this case? I added a test for both cases of using apply_xfm
There was a problem hiding this comment.
what if someone sets them to Undefined
In [1]: from traits.api import Undefined
In [2]: not Undefined
Out[2]: False
There was a problem hiding this comment.
however the check with not appears to work now
There was a problem hiding this comment.
In [20]: foo.inputs.wmnorms = Undefined
In [21]: not foo.inputs.wmnorms
Out[21]: True
haven't figured out why yet
There was a problem hiding this comment.
@satra should this be changed?
Addresses #1317 - allows use of
apply_xfmwith eitherin_matrix_fileoruses_qformargs