[BUG] Fixing CircleCI tests (several issues) #1833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/Dockerfile_base file. closes nipy#1832 (for real)
Codecov Report
@@ Coverage Diff @@
## master #1833 +/- ##
=========================================
Coverage ? 72.73%
=========================================
Files ? 1054
Lines ? 52505
Branches ? 0
=========================================
Hits ? 38192
Misses ? 14313
Partials ? 0
Continue to review full report at Codecov.
|
|
Even thought github thinks the last circleci build is running, the last is https://circleci.com/gh/oesteban/nipype/472?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
timecommand before tests in CircleCI which was preventing errors to propagate to the CircleCI status collection.Additionally, fixes some other problems that have been missed out by the fact that tests were not actually running.