Fix small bug/typo in misc.CreateNifti #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.86% (diff: 100%)@@ master #1781 diff @@
==========================================
Files 1047 1048 +1
Lines 52050 52083 +33
Methods 0 0
Messages 0 0
Branches 7661 7662 +1
==========================================
+ Hits 36349 36386 +37
+ Misses 14123 14118 -5
- Partials 1578 1579 +1
|
satra
reviewed
Jan 16, 2017
| @@ -245,7 +245,7 @@ def _run_interface(self, runtime): | |||
| else: | |||
| affine = None | |||
|
|
|||
| with open(self.inputs.header_file, 'rb') as data_file: | |||
| with open(self.inputs.data_file, 'rb') as data_file: | |||
There was a problem hiding this comment.
this interface seems to only work with hdr/img pair files. in that space, shouldn't this be the header_file?
There was a problem hiding this comment.
I think @alexsavio is right, here. These two lines were originally:
data = hdr.data_from_fileobj(open(self.inputs.data_file, 'rb'))There was a problem hiding this comment.
There was a problem hiding this comment.
You can generate them with nibabel easily enough. e.g.
analyze = nb.AnalyzeImage(np.zeros((3,4,5,6)), np.eye(4))
analyze.to_filename('test.hdr') # Should create test.hdr/test.img
|
Hi, This PR is ready for review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've found a bug in misc.CreateNifti while running Camino tractography workflows.
This seems to fix it.
Cheers,
Alex