FSL FIX wrapper

[chrisgorgo]

No description provided.

[wmpauli]

Is there anything I need to do here? It doesn't seem like the first test (continuous-integration/travis-ci/pr) failed due to a reason related to the fix.py file.

[satra]

@djarecka - the segfault is back!

[djarecka]

@wmpauli - can you please merge your repo with the new nipy:master? We changed the testing framework a few months ago, CI is testing according to your branch and tries to run nosetest, that is not supported anymore.

@satra - travis is "fixed" :) but it looks like the segfault is real, and since wpauli's master is pretty old, it looks like this segfault might have been with us for a while... we should ask people to run travis 50times before accepting PR ;-) Will have to try to reproduce on my laptop, in 3 cases I saw it was always py27.
btw. Do you understand why travis is running py.test and CI uses wpauli master to run nose? Is it expected behavior?

[codecov-io]

Codecov Report

Merging #1780 into master will decrease coverage by -0.03%.
The diff coverage is 63.79%.

@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
- Coverage   69.83%   69.81%   -0.03%     
==========================================
  Files        1047     1048       +1     
  Lines       52050    52166     +116     
  Branches     7661     7658       -3     
==========================================
+ Hits        36349    36418      +69     
- Misses      14123    14163      +40     
- Partials     1578     1585       +7

Flag	Coverage Δ
#unittests	69.81% <63.79%> (-0.03%)	❌

Impacted Files	Coverage Δ
nipype/interfaces/fsl/fix.py	63.79% <63.79%> (ø)
nipype/pipeline/plugins/condor.py	14.7% <0%> (-1.48%)	❌
nipype/pipeline/plugins/pbs.py	19.11% <0%> (-1.48%)	❌
nipype/pipeline/plugins/lsf.py	14.86% <0%> (-1.36%)	❌
nipype/pipeline/plugins/slurm.py	14.66% <0%> (-1.34%)	❌
nipype/pipeline/plugins/oar.py	29.06% <0%> (-1.17%)	❌
nipype/interfaces/mrtrix/convert.py	21.73% <0%> (-0.55%)	❌
nipype/pipeline/plugins/sge.py	17.74% <0%> (-0.44%)	❌
nipype/interfaces/base.py	80.16% <0%> (-0.19%)	❌
nipype/interfaces/dynamic_slicer.py	17.47% <0%> (ø)	✅
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac0cc7...182e7eb. Read the comment docs.

[wmpauli]

@djarecka Sorry about that. I merged, but it still segfaults for the python 2.7 build, with installing_deb_dependencies=true.

[djarecka]

@wmpauli - thanks for merging. The segfault is probably not related to your changes, I've seen segfautls recently in other branches. It doesn't occur every single time, and can jump from one environment to another, just stays within py27. We have to figure this out.

@satra - i didn't get that this is THE segfault... On my laptop I'm getting it for every run.
The one I got 2 weeks ago was actually in a different test, not sure if they might be related: https://travis-ci.org/djarecka/nipype/jobs/189379626

[chrisgorgo]

I rerun the tests and everything seems green.

[wmpauli]

Hooray! Thank you for merging.

…

On Fri, Mar 3, 2017 at 11:37 AM, Chris Filo Gorgolewski < ***@***.***> wrote: I rerun the tests and everything seems green. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1780 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGPHiUK6ZltKbLFKwfV7cat4MC5UyCiZks5riF3OgaJpZM4LkMVl> .