simplifying tests, removing some try/except blocks

[djarecka]

• I left the try/except blocks in test_node_init and test_io_subclass: it looks like the tests should fail only for some exceptions, and others are ok

• I removed also logger.info('Exception: %s' % str(e)) parts, most other test don't have it anyway. I can bring it back if needed.

[codecov-io]

Current coverage is 72.46% (diff: 100%)

Merging #1773 into master will increase coverage by 0.02%

@@             master      #1773   diff @@
==========================================
  Files          1056       1056          
  Lines         52745      52696    -49   
  Methods           0          0          
  Messages          0          0          
  Branches       7663       7663          
==========================================
- Hits          38208      38187    -21   
+ Misses        13326      13298    -28   
  Partials       1211       1211          

Powered by Codecov. Last update 7b5201d...6f5939f

[satra]

can we make this a specific exception, but changing what exception is raised. here it could be a specific exception, like EngineTestException.

[djarecka]

I'm not sure if I understand. Do you want pytest to check specific exceptions or you want to define a class EngineTestException(Exception).

I sometimes ask pytest to check a specific error or exception, but in this case the exception from line 517 was raised (i.e. raise Exception('Submit called')), so to be more specific I could only check the message and I've done it in the line 521 assert 'Submit called' == str(excinfo.value).

[satra]

in this particular case define a specific class and check for that. we shouldn't raise generic exceptions unless absolutely necessary.

[djarecka]

ok, can do it, but the class RaiseError(DistributedPluginBase) is defined within the test function, so it will only influence this specific test and not the general code behavior.

[satra]

correct. most of nipype is ok - we have a couple of general exception catches, mostly because we don't know how python functions or external tools called via subprocess are going to crash

[djarecka]

ok, understand now