[FIX] problems with traits4.6 #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 72.44% (diff: 100%)@@ master #1770 diff @@
==========================================
Files 1056 1055 -1
Lines 52713 52824 +111
Methods 0 0
Messages 0 0
Branches 7660 7673 +13
==========================================
+ Hits 38188 38267 +79
- Misses 13316 13345 +29
- Partials 1209 1212 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1752
It looks like adding additional if statement solves the problem related to a new version of
traits.HasTraits.traits.I'm not sure what is the main purpose of the modified loop, so waiting for other suggestions.