Skip to content

enh: additional eddy inputs #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2017
Merged

enh: additional eddy inputs #1711

merged 6 commits into from
Jan 3, 2017

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Nov 14, 2016

Additional args:

  • is_shelled
  • field and field_mat
  • use_gpu (allows eddy to run with openmp/cuda )

@codecov-io
Copy link

codecov-io commented Nov 14, 2016

Current coverage is 72.43% (diff: 54.54%)

Merging #1711 into master will decrease coverage by 0.01%

@@             master      #1711   diff @@
==========================================
  Files          1056       1056          
  Lines         52713      52723    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       7660       7662     +2   
==========================================
  Hits          38188      38188          
- Misses        13316      13325     +9   
- Partials       1209       1210     +1   

Powered by Codecov. Last update 29ba1b2...8e8f231

elif self.inputs.use_gpu.lower().startswith('openmp'):
_cmd = 'eddy_openmp'
else:
_cmd = 'eddy'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no longer an eddy command i think, so you may need to default to eddy_openmp with n threads of 1.

@satra
Copy link
Member

satra commented Dec 29, 2016

@mgxd - please merge with upstream master to incorporate all the new tests.

@satra satra merged commit 2a9f532 into nipy:master Jan 3, 2017
@mgxd mgxd deleted the enh/eddy branch January 3, 2017 17:18
effigies added a commit to effigies/nipype that referenced this pull request Mar 9, 2017
effigies added a commit to effigies/nipype that referenced this pull request Mar 22, 2017
@mgxd mgxd removed the needs-review label May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants