-
Notifications
You must be signed in to change notification settings - Fork 532
enh: additional eddy inputs #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 72.43% (diff: 54.54%)@@ master #1711 diff @@
==========================================
Files 1056 1056
Lines 52713 52723 +10
Methods 0 0
Messages 0 0
Branches 7660 7662 +2
==========================================
Hits 38188 38188
- Misses 13316 13325 +9
- Partials 1209 1210 +1
|
satra
reviewed
Dec 29, 2016
elif self.inputs.use_gpu.lower().startswith('openmp'): | ||
_cmd = 'eddy_openmp' | ||
else: | ||
_cmd = 'eddy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no longer an eddy command i think, so you may need to default to eddy_openmp with n threads of 1.
@mgxd - please merge with upstream master to incorporate all the new tests. |
2 tasks
effigies
added a commit
to effigies/nipype
that referenced
this pull request
Mar 9, 2017
effigies
added a commit
to effigies/nipype
that referenced
this pull request
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional args: