fix semaphore acquire bug #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this. Noticed this recently and it completely changed how I have to run my processes. I couldn't narrow it down though. |
|
LGTM, but let's wait for the tests to finish. Thanks for sending this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug on how the semaphore of the multiproc plugin was initialized and released.
The semaphore counter was initialized with 1, being acquired over and over again and never released.
That is because semaphore.acquire() was called more times than semaphore.release(), so the semaphore internal counter would always be > 0, leading to the master process to be active all the time.
We noticed that bug because the master process of the run was utilizing 100% cpu, even on the times it was supposed to be sleeping.
This fix makes the multiproc plugin have the expected behavior: the main process sleeps when it is waiting for jobs to finish.
Besides that, the multiproc plugin still works exactly the same as before.