REF/STY Reorganize AFNI interface. #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort imports in afni base. Sort classes in afni preprocess, split several long strings, and replace traits.Str with base Str throughout all classes.
Create utils.py and move several functions from preprocess to utils. Also, add optional arguments to AFNItoNIFTI, standardize long strings and standardize spacing.
# Conflicts: # nipype/interfaces/afni/preprocess.py
FSLOUTTYPE defaults to “nit”, not “nii.gz”.
FSLOUTTYPE must only default to .nii for me.
|
@tsalo - there are a few files added to this pull request which should not be: |
Current coverage is 70.71% (diff: 75.14%)@@ master #1678 diff @@
==========================================
Files 1028 1030 +2
Lines 51612 51868 +256
Methods 0 0
Messages 0 0
Branches 7317 7365 +48
==========================================
+ Hits 36619 36681 +62
- Misses 13904 14096 +192
- Partials 1089 1091 +2
|
|
I'm not sure how they were created, but I've deleted those files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some functions into new utils file. Clean up whitespace. Standardize long strings and whitespace. Reorder functions alphabetically. Add optional arguments to AFNItoNIFTI.