TST Automatic retries in travis #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 22, 2016 22:58
Current coverage is 70.98% (diff: 100%)@@ master #1659 diff @@
==========================================
Files 1027 1027
Lines 51555 51865 +310
Methods 0 0
Messages 0 0
Branches 7301 7385 +84
==========================================
+ Hits 36553 36816 +263
- Misses 13919 13960 +41
- Partials 1083 1089 +6
|
chrisgorgo
reviewed
Sep 23, 2016
| if $INSTALL_DEB_DEPENDECIES; then | ||
| source /etc/fsl/fsl.sh; | ||
| source /etc/afni/afni.sh; fi; | ||
| export FSLOUTPUTTYPE=NIFTI_GZ; } |
There was a problem hiding this comment.
How does failure of one line in this function propagates to the exit code of the whole thing? Since the individual commands are not joined by && wouldn't only the exit code of the last command count in the decision if a retry is needed?
|
I think this is ready for merge (assuming circleci passes) |
|
@chrisfilo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1622
I've finished retries for travis. I need to focus on other things so circle will have to wait.